EditorInitialization: Fix ESLint warnings for internal hooks #59118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
Size Change: -10 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 01a63a4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7927097796
|
tyxla
reviewed
Feb 16, 2024
There was a problem hiding this comment.
Just to make sure I understand: previously, we were re-initializing the post editor when the post changes, and this will no longer be the case after this PR.
That sounds OK for the most part, but I wonder if we're missing a scenario when the post will change without a page reload and we'll need to properly reinitialize like we did before. That scenario could be a third-party plugin one, theoretically.
Otherwise, if we are certain that we don't need to reinitialize when the post ID changes, this is a cool cleanup and a nice find!
WDYT? Should we seek a second opinion?
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
The listener hooks don't need to react to post ID change, even if it happens without page reload due to some third-party integration. They should only react to value changes in store. Passing the unused |
tyxla
approved these changes
Feb 26, 2024
packages/edit-post/src/components/editor-initialization/test/listener-hooks.js
Show resolved
Hide resolved
Mamaduka
force-pushed
the
fix/eslint-warnings-editor-initialization-hooks
branch
from
01a63a4 to
8f47de9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR fixes ESLint warnings for the
EditorInitializationcomponent internal hooks. It mainly removes unnecessarypostIddependency; the hooks don't use the value, and it won't change after the editor is initialized.Testing Instructions
DFM
Testing Instructions for Keyboard
Same.