Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test environment default theme versions to latest. #58955

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Update test environment default theme versions to latest. #58955

merged 1 commit into from
Feb 13, 2024

Conversation

tellthemachines
Copy link
Contributor

What?

The themes in wp-env test environment are out of date and TT1 in particular has a bug that is causing tests to fail on #57841. Updating to the latest version fixes this. Thought I'd also update TT3 while I was at it 😄

Testing Instructions

Check that e2e pass on this branch.

Testing Instructions for Keyboard

Screenshots or screencast

@tellthemachines tellthemachines added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Feb 13, 2024
@tellthemachines tellthemachines self-assigned this Feb 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tellthemachines <[email protected]>
Co-authored-by: youknowriad <[email protected]>
Co-authored-by: getdave <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@tellthemachines tellthemachines mentioned this pull request Feb 13, 2024
Closed
youknowriad
youknowriad approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I'm guessing this might have a small impact on the performance graph but not sure 100%

@getdave getdave merged commit 3f24947 into trunk Feb 13, 2024
65 checks passed
@getdave getdave deleted the update/test-themes branch February 13, 2024 10:48
@github-actions github-actions bot added this to the Gutenberg 17.8 milestone Feb 13, 2024
@tellthemachines
Copy link
Contributor Author

Thanks for merging this folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getdave getdave getdave approved these changes

@youknowriad youknowriad youknowriad approved these changes

@gziolo gziolo Awaiting requested review from gziolo

@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees

@tellthemachines tellthemachines

Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
Gutenberg 17.8
Development

Successfully merging this pull request may close these issues.
3 participants
@tellthemachines @youknowriad @getdave