-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Removing footnotes from the allowed blocks does not remove footnotes #58855
Merged
jorgefilipecosta
merged 1 commit into
trunk
from
fix/removing-footnotes-from-the-allowed-blocks-does-not-removes-footnotes
Feb 9, 2024
Merged
Fix: Removing footnotes from the allowed blocks does not remove footnotes #58855
jorgefilipecosta
merged 1 commit into
trunk
from
fix/removing-footnotes-from-the-allowed-blocks-does-not-removes-footnotes
Feb 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
An existing feature does not function as intended
[Block] Footnotes
Affects the Footnotes Block
labels
Feb 8, 2024
Size Change: +33 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
jorgefilipecosta
deleted the
fix/removing-footnotes-from-the-allowed-blocks-does-not-removes-footnotes
branch
February 9, 2024 09:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Footnotes
Affects the Footnotes Block
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the footnotes format is still available even if the footnotes block is disabled.
This creates an user noticed problem where the user can create footnotes and use the footnote format but can not edit its content.
Testing Instructions
I added the following code in blocks.php:
I created a new post added some text and verified I could not add a footnote. I can add a footnote on the trunk but not edit its content.