Block Bindings: Ensure to pass bound attributes #58844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retrofox
added
[Type] Enhancement
retrofox
requested review from
Mamaduka,
gziolo,
ellatrix,
artemiomorales,
michalczaplinski and
SantosGuillamot
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -1 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
michalczaplinski
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
LGTM! 👍
You should rebase your PR on trunk because there were some failing e2e tests that were fixed in #58843
retrofox
force-pushed
the
update/use-bound-attributes-setting-block-attrs
branch
from
abab6b1
to
afc5569
Compare
|
Flaky tests detected in afc5569. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7834639869
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR ensures passing the update (bound) attributes to the block edit component function.
Why?
Because the
attributesproperty previously defined with the bound attribute is overwritten by the original attributes object though the{ ...props }assignment.How?
Testing Instructions
Testing Instructions for Keyboard
Use testing instructions - #58085.
Screenshots or screencast