DataViews: Use chips for filter summary #58816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +725 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 3f5ed0d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7842604207
|
|
Nice, this is working pretty well already! I pushed some style tweaks but there were a couple of details I could figure out:
|
|
Looking at this with a admin theme, I've noticed two things:
|
oandregal
reviewed
Feb 8, 2024
I think that's fine. This is similar to clicking the
I've added two wrappers, so feel free to add some nice styles there :)
|
ntsekouras
commented
Feb 8, 2024
oandregal
reviewed
Feb 8, 2024
oandregal
reviewed
Feb 8, 2024
oandregal
reviewed
Feb 8, 2024
ntsekouras
force-pushed
the
dataviews/chips-filter-summary
branch
from
370e87b
to
a509c76
Compare
jameskoster
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
This is looking good for an initial implementation.
I suspect we can refine the operator display, but that can happen once we add more than the single is/is not that we have now.
Since the chips include a reset/remove affordance we might consider removing the 'reset'/'remove' button in the filter popover as a follow-up. That would tidy the filter configuration UX up a little.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR redesigns the filter's summary based on the suggested designs.
Notes
Testing instructions