DEWP: Fix script module import field #58770

sirreal · 2024-02-07T10:53:56Z

What?

The script modules proposal shipped with import type field named import not type. Update accordingly.

Testing Instructions

See the snapshot changes and see that they align with the script modules implementation in Gutenberg and Core:

gutenberg/lib/compat/wordpress-6.5/class-wp-script-modules.php

Lines 34 to 95 in 180b57a

    
           		/** 
        
           		 * Registers the script module if no script module with that script module 
        
           		 * identifier has already been registered. 
        
           		 * 
        
           		 * @since 6.5.0 
        
           		 * 
        
           		 * @param string            $id       The identifier of the script module. Should be unique. It will be used in the 
        
           		 *                                    final import map. 
        
           		 * @param string            $src      Optional. Full URL of the script module, or path of the script module relative 
        
           		 *                                    to the WordPress root directory. If it is provided and the script module has 
        
           		 *                                    not been registered yet, it will be registered. 
        
           		 * @param array             $deps     { 
        
           		 *                                        Optional. List of dependencies. 
        
           		 * 
        
           		 *                                        @type string|array $0... { 
        
           		 *                                            An array of script module identifiers of the dependencies of this script 
        
           		 *                                            module. The dependencies can be strings or arrays. If they are arrays, 
        
           		 *                                            they need an `id` key with the script module identifier, and can contain 
        
           		 *                                            an `import` key with either `static` or `dynamic`. By default, 
        
           		 *                                            dependencies that don't contain an `import` key are considered static. 
        
           		 * 
        
           		 *                                            @type string $id     The script module identifier. 
        
           		 *                                            @type string $import Optional. Import type. May be either `static` or 
        
           		 *                                                                 `dynamic`. Defaults to `static`. 
        
           		 *                                        } 
        
           		 *                                    } 
        
           		 * @param string|false|null $version  Optional. String specifying the script module version number. Defaults to false. 
        
           		 *                                    It is added to the URL as a query string for cache busting purposes. If $version 
        
           		 *                                    is set to false, the version number is the currently installed WordPress version. 
        
           		 *                                    If $version is set to null, no version is added. 
        
           		 */ 
        
           		public function register( string $id, string $src, array $deps = array(), $version = false ) { 
        
           			if ( ! isset( $this->registered[ $id ] ) ) { 
        
           				$dependencies = array(); 
        
           				foreach ( $deps as $dependency ) { 
        
           					if ( is_array( $dependency ) ) { 
        
           						if ( ! isset( $dependency['id'] ) ) { 
        
           							_doing_it_wrong( __METHOD__, __( 'Missing required id key in entry among dependencies array.' ), '6.5.0' ); 
        
           							continue; 
        
           						} 
        
           						$dependencies[] = array( 
        
           							'id'     => $dependency['id'], 
        
           							'import' => isset( $dependency['import'] ) && 'dynamic' === $dependency['import'] ? 'dynamic' : 'static', 
        
           						); 
        
           					} elseif ( is_string( $dependency ) ) { 
        
           						$dependencies[] = array( 
        
           							'id'     => $dependency, 
        
           							'import' => 'static', 
        
           						); 
        
           					} else { 
        
           						_doing_it_wrong( __METHOD__, __( 'Entries in dependencies array must be either strings or arrays with an id key.' ), '6.5.0' ); 
        
           					} 
        
           				} 
        
           				$this->registered[ $id ] = array( 
        
           					'src'          => $src, 
        
           					'version'      => $version, 
        
           					'enqueue'      => isset( $this->enqueued_before_registered[ $id ] ), 
        
           					'dependencies' => $dependencies, 
        
           				); 
        
           			} 
        
           		}

github-actions · 2024-02-07T10:56:50Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell, cbravobernal, luisherranz.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sirreal <[email protected]>
Co-authored-by: c4rl0sbr4v0 <[email protected]>
Co-authored-by: luisherranz <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2024-02-07T11:02:20Z

Size Change: 0 B

Total Size: 1.69 MB

ℹ️ View Unchanged

Filename	Size
`build/a11y/index.min.js`	955 B
`build/annotations/index.min.js`	2.69 kB
`build/api-fetch/index.min.js`	2.32 kB
`build/autop/index.min.js`	2.1 kB
`build/blob/index.min.js`	578 B
`build/block-directory/index.min.js`	7.22 kB
`build/block-directory/style-rtl.css`	1.02 kB
`build/block-directory/style.css`	1.02 kB
`build/block-editor/content-rtl.css`	4.35 kB
`build/block-editor/content.css`	4.35 kB
`build/block-editor/default-editor-styles-rtl.css`	381 B
`build/block-editor/default-editor-styles.css`	381 B
`build/block-editor/index.min.js`	251 kB
`build/block-editor/style-rtl.css`	15.5 kB
`build/block-editor/style.css`	15.5 kB
`build/block-library/blocks/archives/editor-rtl.css`	61 B
`build/block-library/blocks/archives/editor.css`	60 B
`build/block-library/blocks/archives/style-rtl.css`	90 B
`build/block-library/blocks/archives/style.css`	90 B
`build/block-library/blocks/audio/editor-rtl.css`	150 B
`build/block-library/blocks/audio/editor.css`	150 B
`build/block-library/blocks/audio/style-rtl.css`	122 B
`build/block-library/blocks/audio/style.css`	122 B
`build/block-library/blocks/audio/theme-rtl.css`	126 B
`build/block-library/blocks/audio/theme.css`	126 B
`build/block-library/blocks/avatar/editor-rtl.css`	116 B
`build/block-library/blocks/avatar/editor.css`	116 B
`build/block-library/blocks/avatar/style-rtl.css`	104 B
`build/block-library/blocks/avatar/style.css`	104 B
`build/block-library/blocks/block/editor-rtl.css`	305 B
`build/block-library/blocks/block/editor.css`	305 B
`build/block-library/blocks/button/editor-rtl.css`	415 B
`build/block-library/blocks/button/editor.css`	414 B
`build/block-library/blocks/button/style-rtl.css`	627 B
`build/block-library/blocks/button/style.css`	626 B
`build/block-library/blocks/buttons/editor-rtl.css`	337 B
`build/block-library/blocks/buttons/editor.css`	337 B
`build/block-library/blocks/buttons/style-rtl.css`	332 B
`build/block-library/blocks/buttons/style.css`	332 B
`build/block-library/blocks/calendar/style-rtl.css`	239 B
`build/block-library/blocks/calendar/style.css`	239 B
`build/block-library/blocks/categories/editor-rtl.css`	113 B
`build/block-library/blocks/categories/editor.css`	112 B
`build/block-library/blocks/categories/style-rtl.css`	124 B
`build/block-library/blocks/categories/style.css`	124 B
`build/block-library/blocks/code/editor-rtl.css`	53 B
`build/block-library/blocks/code/editor.css`	53 B
`build/block-library/blocks/code/style-rtl.css`	121 B
`build/block-library/blocks/code/style.css`	121 B
`build/block-library/blocks/code/theme-rtl.css`	124 B
`build/block-library/blocks/code/theme.css`	124 B
`build/block-library/blocks/columns/editor-rtl.css`	108 B
`build/block-library/blocks/columns/editor.css`	108 B
`build/block-library/blocks/columns/style-rtl.css`	421 B
`build/block-library/blocks/columns/style.css`	421 B
`build/block-library/blocks/comment-author-avatar/editor-rtl.css`	125 B
`build/block-library/blocks/comment-author-avatar/editor.css`	125 B
`build/block-library/blocks/comment-content/style-rtl.css`	92 B
`build/block-library/blocks/comment-content/style.css`	92 B
`build/block-library/blocks/comment-template/style-rtl.css`	199 B
`build/block-library/blocks/comment-template/style.css`	198 B
`build/block-library/blocks/comments-pagination-numbers/editor-rtl.css`	123 B
`build/block-library/blocks/comments-pagination-numbers/editor.css`	121 B
`build/block-library/blocks/comments-pagination/editor-rtl.css`	222 B
`build/block-library/blocks/comments-pagination/editor.css`	209 B
`build/block-library/blocks/comments-pagination/style-rtl.css`	235 B
`build/block-library/blocks/comments-pagination/style.css`	231 B
`build/block-library/blocks/comments-title/editor-rtl.css`	75 B
`build/block-library/blocks/comments-title/editor.css`	75 B
`build/block-library/blocks/comments/editor-rtl.css`	840 B
`build/block-library/blocks/comments/editor.css`	839 B
`build/block-library/blocks/comments/style-rtl.css`	637 B
`build/block-library/blocks/comments/style.css`	636 B
`build/block-library/blocks/cover/editor-rtl.css`	647 B
`build/block-library/blocks/cover/editor.css`	650 B
`build/block-library/blocks/cover/style-rtl.css`	1.69 kB
`build/block-library/blocks/cover/style.css`	1.68 kB
`build/block-library/blocks/details/editor-rtl.css`	65 B
`build/block-library/blocks/details/editor.css`	65 B
`build/block-library/blocks/details/style-rtl.css`	98 B
`build/block-library/blocks/details/style.css`	98 B
`build/block-library/blocks/embed/editor-rtl.css`	322 B
`build/block-library/blocks/embed/editor.css`	322 B
`build/block-library/blocks/embed/style-rtl.css`	410 B
`build/block-library/blocks/embed/style.css`	410 B
`build/block-library/blocks/embed/theme-rtl.css`	126 B
`build/block-library/blocks/embed/theme.css`	126 B
`build/block-library/blocks/file/editor-rtl.css`	316 B
`build/block-library/blocks/file/editor.css`	316 B
`build/block-library/blocks/file/style-rtl.css`	280 B
`build/block-library/blocks/file/style.css`	281 B
`build/block-library/blocks/file/view.min.js`	324 B
`build/block-library/blocks/footnotes/style-rtl.css`	201 B
`build/block-library/blocks/footnotes/style.css`	199 B
`build/block-library/blocks/form-input/editor-rtl.css`	227 B
`build/block-library/blocks/form-input/editor.css`	227 B
`build/block-library/blocks/form-input/style-rtl.css`	343 B
`build/block-library/blocks/form-input/style.css`	343 B
`build/block-library/blocks/form-submission-notification/editor-rtl.css`	340 B
`build/block-library/blocks/form-submission-notification/editor.css`	340 B
`build/block-library/blocks/form-submit-button/style-rtl.css`	69 B
`build/block-library/blocks/form-submit-button/style.css`	69 B
`build/block-library/blocks/form/view.min.js`	471 B
`build/block-library/blocks/freeform/editor-rtl.css`	2.61 kB
`build/block-library/blocks/freeform/editor.css`	2.61 kB
`build/block-library/blocks/gallery/editor-rtl.css`	947 B
`build/block-library/blocks/gallery/editor.css`	952 B
`build/block-library/blocks/gallery/style-rtl.css`	1.72 kB
`build/block-library/blocks/gallery/style.css`	1.72 kB
`build/block-library/blocks/gallery/theme-rtl.css`	108 B
`build/block-library/blocks/gallery/theme.css`	108 B
`build/block-library/blocks/group/editor-rtl.css`	654 B
`build/block-library/blocks/group/editor.css`	654 B
`build/block-library/blocks/group/style-rtl.css`	57 B
`build/block-library/blocks/group/style.css`	57 B
`build/block-library/blocks/group/theme-rtl.css`	78 B
`build/block-library/blocks/group/theme.css`	78 B
`build/block-library/blocks/heading/style-rtl.css`	189 B
`build/block-library/blocks/heading/style.css`	189 B
`build/block-library/blocks/html/editor-rtl.css`	336 B
`build/block-library/blocks/html/editor.css`	337 B
`build/block-library/blocks/image/editor-rtl.css`	863 B
`build/block-library/blocks/image/editor.css`	862 B
`build/block-library/blocks/image/style-rtl.css`	1.6 kB
`build/block-library/blocks/image/style.css`	1.59 kB
`build/block-library/blocks/image/theme-rtl.css`	126 B
`build/block-library/blocks/image/theme.css`	126 B
`build/block-library/blocks/image/view.min.js`	2.02 kB
`build/block-library/blocks/latest-comments/style-rtl.css`	357 B
`build/block-library/blocks/latest-comments/style.css`	357 B
`build/block-library/blocks/latest-posts/editor-rtl.css`	213 B
`build/block-library/blocks/latest-posts/editor.css`	212 B
`build/block-library/blocks/latest-posts/style-rtl.css`	478 B
`build/block-library/blocks/latest-posts/style.css`	478 B
`build/block-library/blocks/list/style-rtl.css`	88 B
`build/block-library/blocks/list/style.css`	88 B
`build/block-library/blocks/media-text/editor-rtl.css`	266 B
`build/block-library/blocks/media-text/editor.css`	263 B
`build/block-library/blocks/media-text/style-rtl.css`	505 B
`build/block-library/blocks/media-text/style.css`	503 B
`build/block-library/blocks/more/editor-rtl.css`	431 B
`build/block-library/blocks/more/editor.css`	431 B
`build/block-library/blocks/navigation-link/editor-rtl.css`	668 B
`build/block-library/blocks/navigation-link/editor.css`	669 B
`build/block-library/blocks/navigation-link/style-rtl.css`	103 B
`build/block-library/blocks/navigation-link/style.css`	103 B
`build/block-library/blocks/navigation-submenu/editor-rtl.css`	296 B
`build/block-library/blocks/navigation-submenu/editor.css`	295 B
`build/block-library/blocks/navigation/editor-rtl.css`	2.25 kB
`build/block-library/blocks/navigation/editor.css`	2.26 kB
`build/block-library/blocks/navigation/style-rtl.css`	2.24 kB
`build/block-library/blocks/navigation/style.css`	2.23 kB
`build/block-library/blocks/navigation/view.min.js`	1.1 kB
`build/block-library/blocks/nextpage/editor-rtl.css`	395 B
`build/block-library/blocks/nextpage/editor.css`	395 B
`build/block-library/blocks/page-list/editor-rtl.css`	377 B
`build/block-library/blocks/page-list/editor.css`	377 B
`build/block-library/blocks/page-list/style-rtl.css`	175 B
`build/block-library/blocks/page-list/style.css`	175 B
`build/block-library/blocks/paragraph/editor-rtl.css`	235 B
`build/block-library/blocks/paragraph/editor.css`	235 B
`build/block-library/blocks/paragraph/style-rtl.css`	335 B
`build/block-library/blocks/paragraph/style.css`	335 B
`build/block-library/blocks/post-author/style-rtl.css`	175 B
`build/block-library/blocks/post-author/style.css`	176 B
`build/block-library/blocks/post-comments-form/editor-rtl.css`	96 B
`build/block-library/blocks/post-comments-form/editor.css`	96 B
`build/block-library/blocks/post-comments-form/style-rtl.css`	508 B
`build/block-library/blocks/post-comments-form/style.css`	508 B
`build/block-library/blocks/post-content/editor-rtl.css`	74 B
`build/block-library/blocks/post-content/editor.css`	74 B
`build/block-library/blocks/post-date/style-rtl.css`	61 B
`build/block-library/blocks/post-date/style.css`	61 B
`build/block-library/blocks/post-excerpt/editor-rtl.css`	71 B
`build/block-library/blocks/post-excerpt/editor.css`	71 B
`build/block-library/blocks/post-excerpt/style-rtl.css`	141 B
`build/block-library/blocks/post-excerpt/style.css`	141 B
`build/block-library/blocks/post-featured-image/editor-rtl.css`	666 B
`build/block-library/blocks/post-featured-image/editor.css`	662 B
`build/block-library/blocks/post-featured-image/style-rtl.css`	342 B
`build/block-library/blocks/post-featured-image/style.css`	342 B
`build/block-library/blocks/post-navigation-link/style-rtl.css`	215 B
`build/block-library/blocks/post-navigation-link/style.css`	214 B
`build/block-library/blocks/post-template/editor-rtl.css`	99 B
`build/block-library/blocks/post-template/editor.css`	98 B
`build/block-library/blocks/post-template/style-rtl.css`	409 B
`build/block-library/blocks/post-template/style.css`	408 B
`build/block-library/blocks/post-terms/style-rtl.css`	96 B
`build/block-library/blocks/post-terms/style.css`	96 B
`build/block-library/blocks/post-time-to-read/style-rtl.css`	69 B
`build/block-library/blocks/post-time-to-read/style.css`	69 B
`build/block-library/blocks/post-title/style-rtl.css`	100 B
`build/block-library/blocks/post-title/style.css`	100 B
`build/block-library/blocks/preformatted/style-rtl.css`	125 B
`build/block-library/blocks/preformatted/style.css`	125 B
`build/block-library/blocks/pullquote/editor-rtl.css`	135 B
`build/block-library/blocks/pullquote/editor.css`	135 B
`build/block-library/blocks/pullquote/style-rtl.css`	354 B
`build/block-library/blocks/pullquote/style.css`	354 B
`build/block-library/blocks/pullquote/theme-rtl.css`	168 B
`build/block-library/blocks/pullquote/theme.css`	168 B
`build/block-library/blocks/query-pagination-numbers/editor-rtl.css`	122 B
`build/block-library/blocks/query-pagination-numbers/editor.css`	121 B
`build/block-library/blocks/query-pagination/editor-rtl.css`	221 B
`build/block-library/blocks/query-pagination/editor.css`	211 B
`build/block-library/blocks/query-pagination/style-rtl.css`	288 B
`build/block-library/blocks/query-pagination/style.css`	284 B
`build/block-library/blocks/query-title/style-rtl.css`	63 B
`build/block-library/blocks/query-title/style.css`	63 B
`build/block-library/blocks/query/editor-rtl.css`	486 B
`build/block-library/blocks/query/editor.css`	486 B
`build/block-library/blocks/query/view.min.js`	996 B
`build/block-library/blocks/quote/style-rtl.css`	237 B
`build/block-library/blocks/quote/style.css`	237 B
`build/block-library/blocks/quote/theme-rtl.css`	223 B
`build/block-library/blocks/quote/theme.css`	226 B
`build/block-library/blocks/read-more/style-rtl.css`	140 B
`build/block-library/blocks/read-more/style.css`	140 B
`build/block-library/blocks/rss/editor-rtl.css`	149 B
`build/block-library/blocks/rss/editor.css`	149 B
`build/block-library/blocks/rss/style-rtl.css`	289 B
`build/block-library/blocks/rss/style.css`	288 B
`build/block-library/blocks/search/editor-rtl.css`	184 B
`build/block-library/blocks/search/editor.css`	184 B
`build/block-library/blocks/search/style-rtl.css`	614 B
`build/block-library/blocks/search/style.css`	614 B
`build/block-library/blocks/search/theme-rtl.css`	114 B
`build/block-library/blocks/search/theme.css`	114 B
`build/block-library/blocks/search/view.min.js`	478 B
`build/block-library/blocks/separator/editor-rtl.css`	146 B
`build/block-library/blocks/separator/editor.css`	146 B
`build/block-library/blocks/separator/style-rtl.css`	229 B
`build/block-library/blocks/separator/style.css`	229 B
`build/block-library/blocks/separator/theme-rtl.css`	194 B
`build/block-library/blocks/separator/theme.css`	194 B
`build/block-library/blocks/shortcode/editor-rtl.css`	323 B
`build/block-library/blocks/shortcode/editor.css`	323 B
`build/block-library/blocks/site-logo/editor-rtl.css`	754 B
`build/block-library/blocks/site-logo/editor.css`	754 B
`build/block-library/blocks/site-logo/style-rtl.css`	204 B
`build/block-library/blocks/site-logo/style.css`	204 B
`build/block-library/blocks/site-tagline/editor-rtl.css`	86 B
`build/block-library/blocks/site-tagline/editor.css`	86 B
`build/block-library/blocks/site-title/editor-rtl.css`	116 B
`build/block-library/blocks/site-title/editor.css`	116 B
`build/block-library/blocks/site-title/style-rtl.css`	57 B
`build/block-library/blocks/site-title/style.css`	57 B
`build/block-library/blocks/social-link/editor-rtl.css`	184 B
`build/block-library/blocks/social-link/editor.css`	184 B
`build/block-library/blocks/social-links/editor-rtl.css`	682 B
`build/block-library/blocks/social-links/editor.css`	681 B
`build/block-library/blocks/social-links/style-rtl.css`	1.49 kB
`build/block-library/blocks/social-links/style.css`	1.48 kB
`build/block-library/blocks/spacer/editor-rtl.css`	348 B
`build/block-library/blocks/spacer/editor.css`	348 B
`build/block-library/blocks/spacer/style-rtl.css`	48 B
`build/block-library/blocks/spacer/style.css`	48 B
`build/block-library/blocks/table/editor-rtl.css`	395 B
`build/block-library/blocks/table/editor.css`	395 B
`build/block-library/blocks/table/style-rtl.css`	639 B
`build/block-library/blocks/table/style.css`	639 B
`build/block-library/blocks/table/theme-rtl.css`	146 B
`build/block-library/blocks/table/theme.css`	146 B
`build/block-library/blocks/tag-cloud/style-rtl.css`	251 B
`build/block-library/blocks/tag-cloud/style.css`	253 B
`build/block-library/blocks/template-part/editor-rtl.css`	403 B
`build/block-library/blocks/template-part/editor.css`	403 B
`build/block-library/blocks/template-part/theme-rtl.css`	101 B
`build/block-library/blocks/template-part/theme.css`	101 B
`build/block-library/blocks/term-description/style-rtl.css`	111 B
`build/block-library/blocks/term-description/style.css`	111 B
`build/block-library/blocks/text-columns/editor-rtl.css`	95 B
`build/block-library/blocks/text-columns/editor.css`	95 B
`build/block-library/blocks/text-columns/style-rtl.css`	166 B
`build/block-library/blocks/text-columns/style.css`	166 B
`build/block-library/blocks/verse/style-rtl.css`	99 B
`build/block-library/blocks/verse/style.css`	99 B
`build/block-library/blocks/video/editor-rtl.css`	552 B
`build/block-library/blocks/video/editor.css`	555 B
`build/block-library/blocks/video/style-rtl.css`	185 B
`build/block-library/blocks/video/style.css`	185 B
`build/block-library/blocks/video/theme-rtl.css`	126 B
`build/block-library/blocks/video/theme.css`	126 B
`build/block-library/classic-rtl.css`	179 B
`build/block-library/classic.css`	179 B
`build/block-library/common-rtl.css`	1.1 kB
`build/block-library/common.css`	1.1 kB
`build/block-library/editor-elements-rtl.css`	75 B
`build/block-library/editor-elements.css`	75 B
`build/block-library/editor-rtl.css`	12.3 kB
`build/block-library/editor.css`	12.3 kB
`build/block-library/elements-rtl.css`	54 B
`build/block-library/elements.css`	54 B
`build/block-library/index.min.js`	215 kB
`build/block-library/reset-rtl.css`	472 B
`build/block-library/reset.css`	472 B
`build/block-library/style-rtl.css`	14.7 kB
`build/block-library/style.css`	14.7 kB
`build/block-library/theme-rtl.css`	688 B
`build/block-library/theme.css`	693 B
`build/block-serialization-default-parser/index.min.js`	1.12 kB
`build/block-serialization-spec-parser/index.min.js`	2.87 kB
`build/blocks/index.min.js`	51.6 kB
`build/commands/index.min.js`	15.5 kB
`build/commands/style-rtl.css`	921 B
`build/commands/style.css`	918 B
`build/components/index.min.js`	226 kB
`build/components/style-rtl.css`	12 kB
`build/components/style.css`	12 kB
`build/compose/index.min.js`	12.6 kB
`build/core-commands/index.min.js`	2.71 kB
`build/core-data/index.min.js`	72.7 kB
`build/customize-widgets/index.min.js`	12.1 kB
`build/customize-widgets/style-rtl.css`	1.34 kB
`build/customize-widgets/style.css`	1.33 kB
`build/data-controls/index.min.js`	640 B
`build/data/index.min.js`	8.92 kB
`build/date/index.min.js`	17.9 kB
`build/deprecated/index.min.js`	451 B
`build/dom-ready/index.min.js`	324 B
`build/dom/index.min.js`	4.65 kB
`build/edit-post/classic-rtl.css`	544 B
`build/edit-post/classic.css`	545 B
`build/edit-post/index.min.js`	25.1 kB
`build/edit-post/style-rtl.css`	5.66 kB
`build/edit-post/style.css`	5.66 kB
`build/edit-site/index.min.js`	195 kB
`build/edit-site/style-rtl.css`	15.2 kB
`build/edit-site/style.css`	15.2 kB
`build/edit-widgets/index.min.js`	17.3 kB
`build/edit-widgets/style-rtl.css`	4.23 kB
`build/edit-widgets/style.css`	4.23 kB
`build/editor/index.min.js`	61.7 kB
`build/editor/style-rtl.css`	5.42 kB
`build/editor/style.css`	5.42 kB
`build/element/index.min.js`	4.83 kB
`build/escape-html/index.min.js`	537 B
`build/format-library/index.min.js`	7.85 kB
`build/format-library/style-rtl.css`	478 B
`build/format-library/style.css`	477 B
`build/hooks/index.min.js`	1.55 kB
`build/html-entities/index.min.js`	448 B
`build/i18n/index.min.js`	3.58 kB
`build/interactivity/file.min.js`	447 B
`build/interactivity/image.min.js`	2.15 kB
`build/interactivity/index.min.js`	12.9 kB
`build/interactivity/navigation.min.js`	1.24 kB
`build/interactivity/query.min.js`	776 B
`build/interactivity/router.min.js`	1.24 kB
`build/interactivity/search.min.js`	618 B
`build/is-shallow-equal/index.min.js`	527 B
`build/keyboard-shortcuts/index.min.js`	1.74 kB
`build/keycodes/index.min.js`	1.46 kB
`build/list-reusable-blocks/index.min.js`	2.11 kB
`build/list-reusable-blocks/style-rtl.css`	836 B
`build/list-reusable-blocks/style.css`	836 B
`build/media-utils/index.min.js`	2.9 kB
`build/modules/importmap-polyfill.min.js`	12.2 kB
`build/notices/index.min.js`	948 B
`build/nux/index.min.js`	2 kB
`build/nux/style-rtl.css`	735 B
`build/nux/style.css`	732 B
`build/patterns/index.min.js`	5.74 kB
`build/patterns/style-rtl.css`	540 B
`build/patterns/style.css`	539 B
`build/plugins/index.min.js`	1.8 kB
`build/preferences-persistence/index.min.js`	2.07 kB
`build/preferences/index.min.js`	2.82 kB
`build/preferences/style-rtl.css`	698 B
`build/preferences/style.css`	700 B
`build/primitives/index.min.js`	975 B
`build/priority-queue/index.min.js`	1.52 kB
`build/private-apis/index.min.js`	1 kB
`build/react-i18n/index.min.js`	623 B
`build/react-refresh-entry/index.min.js`	9.47 kB
`build/react-refresh-runtime/index.min.js`	6.78 kB
`build/redux-routine/index.min.js`	2.7 kB
`build/reusable-blocks/index.min.js`	2.72 kB
`build/reusable-blocks/style-rtl.css`	243 B
`build/reusable-blocks/style.css`	243 B
`build/rich-text/index.min.js`	10.4 kB
`build/router/index.min.js`	1.79 kB
`build/server-side-render/index.min.js`	1.95 kB
`build/shortcode/index.min.js`	1.39 kB
`build/style-engine/index.min.js`	2.08 kB
`build/token-list/index.min.js`	582 B
`build/url/index.min.js`	3.72 kB
`build/vendors/inert-polyfill.min.js`	2.48 kB
`build/vendors/react-dom.min.js`	41.8 kB
`build/vendors/react.min.js`	4.02 kB
`build/viewport/index.min.js`	957 B
`build/warning/index.min.js`	249 B
`build/widgets/index.min.js`	7.21 kB
`build/widgets/style-rtl.css`	1.15 kB
`build/widgets/style.css`	1.16 kB
`build/wordcount/index.min.js`	1.02 kB

_{compressed-size-action}

cbravobernal

LGTM

luisherranz

LGTM!

The import type field was released as import, not type

sirreal marked this pull request as ready for review February 7, 2024 10:56

sirreal requested a review from gziolo as a code owner February 7, 2024 10:56

sirreal requested review from luisherranz and cbravobernal February 7, 2024 10:56

sirreal added [Type] Bug An existing feature does not function as intended [Tool] Dependency Extraction Webpack Plugin /packages/dependency-extraction-webpack-plugin labels Feb 7, 2024

cbravobernal approved these changes Feb 7, 2024

View reviewed changes

sirreal enabled auto-merge (squash) February 7, 2024 11:15

sirreal self-assigned this Feb 7, 2024

luisherranz approved these changes Feb 7, 2024

View reviewed changes

sirreal disabled auto-merge February 7, 2024 11:35

sirreal enabled auto-merge (squash) February 7, 2024 11:35

sirreal added 3 commits February 7, 2024 16:53

Use import instead of type field

6f7acac

The import type field was released as import, not type

Update snaps

1c14461

fix changelog PR number

857e8be

sirreal force-pushed the fix/dewp-use-import-field branch from c1a7841 to 857e8be Compare February 7, 2024 15:53

sirreal merged commit de2a8a7 into trunk Feb 7, 2024
57 checks passed

sirreal deleted the fix/dewp-use-import-field branch February 7, 2024 16:24

github-actions bot added this to the Gutenberg 17.7 milestone Feb 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DEWP: Fix script module import field #58770

DEWP: Fix script module import field #58770

sirreal commented Feb 7, 2024 •

edited

Loading

github-actions bot commented Feb 7, 2024 •

edited

Loading

github-actions bot commented Feb 7, 2024 •

edited

Loading

cbravobernal left a comment

luisherranz left a comment

	/**
	* Registers the script module if no script module with that script module
	* identifier has already been registered.
	*
	* @since 6.5.0
	*
	* @param string $id The identifier of the script module. Should be unique. It will be used in the
	* final import map.
	* @param string $src Optional. Full URL of the script module, or path of the script module relative
	* to the WordPress root directory. If it is provided and the script module has
	* not been registered yet, it will be registered.
	* @param array $deps {
	* Optional. List of dependencies.
	*
	* @type string\|array $0... {
	* An array of script module identifiers of the dependencies of this script
	* module. The dependencies can be strings or arrays. If they are arrays,
	* they need an `id` key with the script module identifier, and can contain
	* an `import` key with either `static` or `dynamic`. By default,
	* dependencies that don't contain an `import` key are considered static.
	*
	* @type string $id The script module identifier.
	* @type string $import Optional. Import type. May be either `static` or
	* `dynamic`. Defaults to `static`.
	* }
	* }
	* @param string\|false\|null $version Optional. String specifying the script module version number. Defaults to false.
	* It is added to the URL as a query string for cache busting purposes. If $version
	* is set to false, the version number is the currently installed WordPress version.
	* If $version is set to null, no version is added.
	*/
	public function register( string $id, string $src, array $deps = array(), $version = false ) {
	if ( ! isset( $this->registered[ $id ] ) ) {
	$dependencies = array();
	foreach ( $deps as $dependency ) {
	if ( is_array( $dependency ) ) {
	if ( ! isset( $dependency['id'] ) ) {
	_doing_it_wrong( __METHOD__, __( 'Missing required id key in entry among dependencies array.' ), '6.5.0' );
	continue;
	}
	$dependencies[] = array(
	'id' => $dependency['id'],
	'import' => isset( $dependency['import'] ) && 'dynamic' === $dependency['import'] ? 'dynamic' : 'static',
	);
	} elseif ( is_string( $dependency ) ) {
	$dependencies[] = array(
	'id' => $dependency,
	'import' => 'static',
	);
	} else {
	_doing_it_wrong( __METHOD__, __( 'Entries in dependencies array must be either strings or arrays with an id key.' ), '6.5.0' );
	}
	}

	$this->registered[ $id ] = array(
	'src' => $src,
	'version' => $version,
	'enqueue' => isset( $this->enqueued_before_registered[ $id ] ),
	'dependencies' => $dependencies,
	);
	}
	}

DEWP: Fix script module import field #58770

DEWP: Fix script module import field #58770

Conversation

sirreal commented Feb 7, 2024 • edited Loading

What?

Testing Instructions

github-actions bot commented Feb 7, 2024 • edited Loading

Core SVN

GitHub Merge commits

github-actions bot commented Feb 7, 2024 • edited Loading

cbravobernal left a comment

Choose a reason for hiding this comment

luisherranz left a comment

Choose a reason for hiding this comment

sirreal commented Feb 7, 2024 •

edited

Loading

github-actions bot commented Feb 7, 2024 •

edited

Loading

github-actions bot commented Feb 7, 2024 •

edited

Loading