Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactivity API: Fix state intialization for asynchronous private stores #58754

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

DAreRodz
Copy link
Contributor

@DAreRodz DAreRodz commented Feb 6, 2024

What?

Fixes a bug that appears when a private store is loaded asynchronously, and the page contains the initial state for that store.

Why?

The current implementation makes those stores become public, thus making private stores throw an error when they try to lock their namespace.

How?

Using the universalUnlock variable defined in store.ts. That prevents the store from being marked as "public" and can be set as "private" later on.

@DAreRodz DAreRodz added [Type] Bug An existing feature does not function as intended [Feature] Interactivity API API to add frontend interactivity to blocks. [Packages] Interactivity /packages/interactivity labels Feb 6, 2024
@DAreRodz DAreRodz marked this pull request as ready for review February 6, 2024 22:38
Copy link

github-actions bot commented Feb 6, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props darerodz, luisherranz.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: DAreRodz <[email protected]>
Co-authored-by: luisherranz <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@luisherranz luisherranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DAreRodz DAreRodz merged commit 8f8c4d7 into trunk Feb 7, 2024
60 checks passed
@DAreRodz DAreRodz deleted the fix/interactivity-api-initial-state-private-stores branch February 7, 2024 09:32
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Interactivity API API to add frontend interactivity to blocks. [Packages] Interactivity /packages/interactivity [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants