Update dataviews search input placeholder #58742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
Size Change: +283 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
oandregal
approved these changes
Feb 6, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
approved these changes
Feb 7, 2024
Mamaduka
reviewed
Feb 7, 2024
Comment on lines
53
to
54
| await page.getByRole( 'searchbox', { name: 'Search' } ).click(); | ||
| await page.keyboard.type( 'tag' ); |
There was a problem hiding this comment.
It's probably better to use fill() for similar cases unless we specifically test typing in the input. It will handle input focus for us.
await page.getByRole( 'searchbox', { name: 'Search' } ).fill( 'tag' );There was a problem hiding this comment.
Thank you for the advice. Updated 👍
|
Gone ahead and merged. Following the new commit message requirements (for having better attribution), I've copied what the props bot suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the search input placeholder in data views to read "Search" rather than "Filter list"
Why?