Site editor: add pattern/template load performance test with TT4 #58734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +17.5 kB (+1%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Feb 8, 2024
|
At some point, we might want to consolidate the themes used in performance tests. |
|
So this tests the "replace template" flow and the other one tests "patterns in inserter" right? |
youknowriad
reviewed
Feb 8, 2024
| } ) | ||
| ); | ||
|
|
||
| const endTime = performance.now(); |
There was a problem hiding this comment.
I think relying on waiting and timers like that might not be very stable but we can see over time.
There was a problem hiding this comment.
It's what we're using for the other patterns load test as well, and also load in general I think
|
I added the metric to codevitals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds a test for pattern/template load in the site editor through the "replace template" flow.
Why?
These templates in particular are much slower to load because they contain patterns that are replaced on load. It is good to have some "real life" performance test for template/pattern previewing with TT4.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast