Add the block name to the pattern content data #58715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
talldan
force-pushed
the
add/block-name-to-pattern-content-data
branch
from
96e2b81
to
f29d615
Compare
|
Size Change: +9 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
What do you think if we prepend the name to the id instead? So |
Yep, this is the reason I avoided that approach. I also never like having to split strings to retrieve data, I think the code is cleaner with it being a separate property. I don't think the extra bytes are too much of an issue, the data would still be much less than the full serialized markup of the pattern. |
kevin940726
approved these changes
Feb 7, 2024
Yeh, I agree with this, plus we still haven't made a call on whether id will be used to track shuffling content, etc. so combining the name and id here would limit our ability to let the user set their own meaningful id as an approach to solve this. |
49 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #53705.
Proposes adding the block name to the pattern content data.
Currently in
trunkthe data is just in this form:There's no way to decipher which block the
textvalue might be for.This PR updates it to look like this:
Why?
As discussed in the tracking issue (#53705 (comment)), I believe this could be useful and could support features like:
Because this data is stored, I think it's better to add this new property earlier so that it's in widespread usage before the feature is launched.
How?
Add the
block.nameas a propertyTesting Instructions
Expected, you should see a content value that looks like this: