Template Part: Derive 'hasInnerBlocks' inside selector #58680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Feb 5, 2024
Comment on lines
-85
to
-87
| // Set the postId block attribute if it did not exist, | ||
| // but wait until the inner blocks have loaded to allow | ||
| // new edits to trigger this. |
There was a problem hiding this comment.
The logic that this comment refers to was removed in #27910.
Mamaduka
requested review from
talldan and
ellatrix
and removed request for
ajitbohra
|
Size Change: -2 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR updates the
TemplatePartEditcomponent to derive the 'hasInnerBlocks' inside the selector.Why?
The component wasn't using any values from the object, so it's better to return
boolean.Testing Instructions
Testing Instructions for Keyboard
Same