Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Bindings: Add tests for the frontend and polish the existing ones #58676

Merged
merged 12 commits into from
Feb 6, 2024
Merged

Block Bindings: Add tests for the frontend and polish the existing ones #58676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
685fb62
Add editor `updatePost` helper in e2e tests
SantosGuillamot Feb 5, 2024
58c2769
Update default url custom field value
SantosGuillamot Feb 5, 2024
89feb91
Test the frontend shows the custom fields values
SantosGuillamot Feb 5, 2024
34a2255
Use `toHaveText` assertion
SantosGuillamot Feb 5, 2024
3ddb71c
Use `toHaveAttribute` assertion
SantosGuillamot Feb 5, 2024
7091e84
Inline variables and primitives
SantosGuillamot Feb 5, 2024
9842c15
Define blocks inside `inserBlock` instead of variables
SantosGuillamot Feb 5, 2024
1c0f768
Nest locators to clarify the scopes
SantosGuillamot Feb 5, 2024
05a1e8d
Use `toHaveAttribute` for `contenteditable`
SantosGuillamot Feb 5, 2024
14c93b1
Use `toHaveText` in buttons
SantosGuillamot Feb 5, 2024
403e0f8
Move `updatePost` helper to bindings test
SantosGuillamot Feb 5, 2024
9fbb7d6
Narrow down update locator
SantosGuillamot Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/e2e-tests/plugins/block-bindings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function gutenberg_test_block_bindings_register_custom_fields() {
'show_in_rest' => true,
'type' => 'string',
'single' => true,
'default' => '',
'default' => '#url-custom-field',
)
);
}
Expand Down
Loading
Loading