Temporarily Disable Font Library Editor UI outside of Gutenberg Plugin #58613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Code Quality
25 tasks
getdave
changed the title
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
|
Flaky tests detected in d82f173. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7756225277
|
I think @hellofromtonya is better qualified to answer this question. Tagging for more visibility. |
|
When are the site editor packages begin updated in Core? I think this PR is only needed if the Font REST API controllers aren't able to be merged before the package updates that would turn on the Font Library in Core. |
|
As @creativecoder points out, this PR is necessary IF:
|
|
The package update actually already happened and on Core trunk, the font library is already broken. So it's either:
At this point, it seems that the first option is the one we're going with. I don't see us not merging the REST API PR. |
|
Yes. Luckily once the Core PRs were up it proved relatively simple to get them merged so we didn't have that long with a broken experience on WP Core trunk. Thanks for input folks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Disables Font Library within the editor outside of the Gutenberg Plugin.
Why?
The "view" code for the Font Library within the editor will be included in WP Core. However, the PHP code which supports this is going to be merge incrementally. Therefore we should temporarily disable the UI until the PHP code is fully landed in Core for the WP 6.5 Beta.
How?
Sets the editor setting conditionally based on whether we are running in the Gutenberg Plugin.
Testing Instructions
packages/editor/src/store/defaults.jsTesting Instructions for Keyboard
Screenshots or screencast