Fix: use old template panel if user doesn’t have access to view templates #58485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiankaegy
added
[Type] Bug
|
Size Change: +35 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
fabiankaegy
requested review from
draganescu,
Mamaduka,
colorful-tones,
getdave and
talldan
|
Flaky tests detected in be606db. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7722574789
|
fabiankaegy
force-pushed
the
fix/template-selection-for-non-admins
branch
from
28c78c5
to
be606db
Compare
|
@fabiankaegy, which bundled theme are you using for testing? |
|
@Mamaduka I'm using 2024 (a block theme but logged in as a user with a role lower than admin) |
|
@draganescu Yes and no, even if this check were to check for See #58301 for more details on the actual long term fix I would like to land instead of this "hotfix" here |
Mamaduka
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Thank you, @fabiankaegy!
The changes test well for me, and I think it is a cute short-term fix.
Like you said a better solution would be introducing proper capabilities for templates and utilizing them in the editors.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Make it possible for non administrators to switch between templates again.
Closing: #58037
This fix is an alternative approach to #58301. #58301 tries to solve it whilst still retaining the ability for editors to preview the template in the editor where as this PR here only restores the old behavior.
I personally would very much preffer #58301 since I think the template preview is a very valuable feature that editors should have access to. But as far as 6.5 goes this here may be the stop gap solution we need.
Why?
Because a regression was introduced in #56817
How?
By checking if the current user can view the templates post type and if not rendering the classic control.
Testing Instructions