-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date: merge 6.4 and 6.5 compat files #58479
Conversation
…e_wp_date_settings(), and stores them in a single place in compat/6.5.
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.4/script-loader.php ❔ lib/compat/wordpress-6.5/script-loader.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes work as expected. Thank you, @ramonjd!
This comment was marked as resolved.
This comment was marked as resolved.
Thanks for confirming. |
Resolves #58431
What and how?
This commit merges the 6.4 and 6.5 compat changes for
gutenberg_update_wp_date_settings()
, and stores them in a single place in compat/6.5.6.4 compat changes (already merged to Core for 6.4)
6.5 compat changes (needs backporting for 6.5)
Why?
Compat code consolidation and to avoid duplicate filters.
Testing Instructions
Fire up this branch and open the editor.
In the browser console, run
wp.date.getSettings()
.Check that properties exist for:
timezone.offsetFormatted
existsl10n.relative.*
existsSmoke test functionality.
wp.date.humanTimeDiff( new Date() )
in the console. You should see a relative translation"a second ago"