Tweak Media & Text inspector controls #58447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
changed the title
|
Size Change: +8 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in bedbacede8d0ac15b2994e5076e153a1455d0799. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7712274029
|
richtabor
added
[Block] Media & Text
richtabor
added
the
[Feature] Inspector Controls
jameskoster
approved these changes
Jan 30, 2024
t-hamano
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Make width always render, not dependent on media
I think this makes sense. When a user creates a pattern that includes this block, there may be a use case where they want to define an explicit width but want the media to be empty. Also, I don't think there will be any problems with always displaying this setting.
richtabor
force-pushed
the
tweak/media-text-inspector
branch
from
98fe345 to
61da11c
Compare
|
Nice one. Not a blocker, should we apply $radius-block-ui (2px) to the focal point picker? |
Yes! I went in on #58459 with that improvement, as well as a few others |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
carolinan
added a commit
that referenced
this pull request
Mar 8, 2024
Move the media width control and update the "crop image to fill" label to better match the changes in #58447.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
__next40pxDefaultSizeon the RangeControl.Testing Instructions
Screenshots or screencast