-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Hooks API: Update doc block for block_core_navigation_insert_hooked_blocks #58378
Merged
youknowriad
merged 5 commits into
WordPress:trunk
from
tjcafferkey:update/core-navigation-block-hooks-doc-block
Jan 30, 2024
Merged
Block Hooks API: Update doc block for block_core_navigation_insert_hooked_blocks #58378
youknowriad
merged 5 commits into
WordPress:trunk
from
tjcafferkey:update/core-navigation-block-hooks-doc-block
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjcafferkey
changed the title
Update doc block for block_core_navigation_insert_hooked_blocks
Block Hooks API: Update doc block for block_core_navigation_insert_hooked_blocks
Jan 29, 2024
3 tasks
youknowriad
added
the
Backport to Gutenberg RC
Pull request that needs to be backported to a Gutenberg release candidate (RC)
label
Jan 29, 2024
ockham
reviewed
Jan 29, 2024
ockham
reviewed
Jan 29, 2024
Co-authored-by: Bernie Reiter <[email protected]>
ockham
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
youknowriad
reviewed
Jan 29, 2024
cbravobernal
pushed a commit
that referenced
this pull request
Jan 30, 2024
…oked_blocks (#58378) Co-authored-by: Bernie Reiter <[email protected]>
I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: ba74bfc |
cbravobernal
removed
the
Backport to Gutenberg RC
Pull request that needs to be backported to a Gutenberg release candidate (RC)
label
Jan 30, 2024
youknowriad
pushed a commit
that referenced
this pull request
Jan 31, 2024
…oked_blocks (#58378) Co-authored-by: Bernie Reiter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Navigation
Affects the Navigation Block
[Type] Developer Documentation
Documentation for developers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updating doc block for
block_core_navigation_insert_hooked_blocks
used in the core Navigation blockWhy?
It was caught and highlighted during the package updates for 6.5 here and requires a PR in GB to fix WordPress/wordpress-develop#5922 (comment)
How?
It's implementing suggested changes which are directly copied from Gutenberg.