Site Editor: Hide export button if non-block-based theme #58346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +9 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 07b6584. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7676676542
|
carolinan
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Part of the testing instructions for this PR are in #58345
Before: Exporting a classic theme creates a zip of the theme with an empty theme.json, parts, and templates folders.
With the PR: the export option is not available, so there is less risk of confusion for classic theme users.
Block themes can still be exported.
|
@carolinan Thanks for the review! It seems that React Native E2E Tests are also failing on trunk, so I would like to update and merge this PR after that issue is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR hides the theme's export button when it is not a block theme.
Why?
My understanding is that this feature, as the text suggests, exports updated templates and global styles. However, since neither templates nor global styles are used in the classic theme, I don't think they should be displayed.
How?
Hides the button if it's not a block theme.
Testing Instructions
localhost:8889/wp-admin