Build: Add package build shebang and sync comments #58264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows us to run build directly: ./bin/packages/build.js
sirreal
requested review from
gziolo,
ntwb,
nerrad and
ajitbohra
as code owners
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Jan 25, 2024
Maybe DEWP could be the single source of truth. It doesn't require a build step, so we wouldn't have a problem where building packages requires on a package being built 🙂 It could expose either this data or a function like |
|
That could work. I think we need to be able to do something similar in WP core in the webpack config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Two small build-related improvements I added to #58258 then extracted here.
bin/packages/build.js. This allows it to be called directly. It was already executable but was missing this.BUNDLED_PACKAGESstating that they should remain in sync and referencing the other location.Why?
Self explanatory.
Testing Instructions
This works: