Block Bindings: Fix bindings image placeholder showing in patterns overrides #58252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Bug
SantosGuillamot
requested review from
talldan,
gziolo,
glendaviesnz and
kevin940726
SantosGuillamot
requested review from
artemiomorales and
michalczaplinski
as code owners
gziolo
reviewed
Jan 25, 2024
| @@ -333,7 +334,26 @@ export function ImageEdit( { | |||
| } ); | |||
|
|
|||
| // Much of this description is duplicated from MediaPlaceholder. | |||
| const isUrlAttributeConnected = !! metadata?.bindings?.url; | |||
| const { lockUrlControls = false } = useSelect( | |||
There was a problem hiding this comment.
Technically speaking, there is no need to return an object if there is only a single return value. Anyway, we can refactor that later when we introduce the helper React hook as discussed in #58233.
|
Size Change: +20 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
gziolo
added
the
[Feature] Synced Patterns
SantosGuillamot
deleted the
fix/block-bindings-image-placeholder-in-patterns
branch
cbravobernal
pushed a commit
that referenced
this pull request
Jan 30, 2024
|
I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: 6faff4e |
cbravobernal
removed
the
Backport to Gutenberg RC
youknowriad
pushed a commit
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix an issue where the image placeholder we created for block bindings was showing when adding an empty image in a pattern overrides.
Why?
Pattern overrides creators should be able to insert any media if wanted.
How?
I'm changing the conditional to understand that, in case of pattern overrides, it should show the normal placeholder.
Testing Instructions
In
trunkright now, this placeholder is shown instead: