Fix line-height in block card. #58246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -56 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Good catch. Probably worth applying the fix to 
|
|
Good catch. We really need to unify those codebases! 🙈 |
jameskoster
approved these changes
Jan 25, 2024
MaggieCabrera
added
General Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When the block card has a long title, the title in the inspector wraps and has a too tall lineheight:
Here's a short title, where it's not visible:
This PR makes the title line-height the same as the description, addressing this:
Short titles look the same:
Testing Instructions
Create a synced block with a very long title, and observe the line-height of the wrapping title in the inspector to be the same as that of the description below.