Removed <header> <main> and <footer> elements from Font Library Modal #58221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v> elements and assigned new class names to leverage existing styles
pbking
changed the title
pbking
changed the title
pbking
added
[Feature] Font Library
[Focus] Accessibility (a11y)
|
Size Change: -1 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in cbd40bc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7646170199
|
mikachan
added
the
Backport to Gutenberg RC
cbravobernal
deleted the
fix/font-modal-remove-header-footer-main-elements
branch
cbravobernal
pushed a commit
that referenced
this pull request
Jan 25, 2024
…v> elements and assigned new class names to leverage existing styles (#58221) Co-authored-by: Sarah Norris <[email protected]>
cbravobernal
removed
the
Backport to Gutenberg RC
|
I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: 1a220b5 |
cbravobernal
pushed a commit
that referenced
this pull request
Jan 25, 2024
…v> elements and assigned new class names to leverage existing styles (#58221) Co-authored-by: Sarah Norris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes
<header><main>and<footer>elements from the Font Library modal to better support assistive technologies.Fixes #58065
How?
<header>element (it wasn't needed)<main>and<footer>elements to<div>elements and assign new classes to them to leverage the existing styles.Open the Font Library modal. Visit all of the tabs. Note that there are no
or elements. Ensure that the design looks the same as it did before this change.