Site editor: avoid double post content parse (alternative) #58146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +43 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
I think this is addressing the same issue as #57500 |
|
To be clear, I don't have full 100% confidence in my PR but I do believe that it's probably something that should be absorbed by the framework and not solved at the component level. |
|
@youknowriad Would this be ok as a temporary solution to avoid the double parse? |
youknowriad
reviewed
Jan 29, 2024
| } else { | ||
| editedBlocks = EMPTY_ARRAY; | ||
| } | ||
| } |
There was a problem hiding this comment.
Why did you decide to move this code inside useSelect calls. I'm worried about parse within useSelect, can we move it to the previous useMemo instead? I think it might be clearer as well.
There was a problem hiding this comment.
Sure, I guess I can pass the entity record to the component
ellatrix
force-pushed
the
try/site-editor-avoid-double-parse-2
branch
from
0dc3143
to
c6877eb
Compare
youknowriad
reviewed
Jan 31, 2024
| const editedRecord = getEditedEntityRecord( kind, name, id ); | ||
| return { | ||
| editedBlocks: editedRecord.blocks, | ||
| content: editedRecord.content, | ||
| meta: editedRecord.meta, | ||
| entityRecord: getEntityRecord( kind, name, id ), |
There was a problem hiding this comment.
I think we don't really need the entityRecord to trigger a pre-render, we should just use getEntityRecord within the blocks computation.
There was a problem hiding this comment.
You mean like this? b332cf9
I think it doesn't matter much because the entityRecord will never change, unlike the edited entity record, which is why we use it as a cache key.
youknowriad
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Similar to #57863, but without changes to existing selectors.
Why?
In the Site Editor,
useEntityBlockEditoris called twice (top level and inside the post content block) with the same record ID, so the content gets parsed twice because it only memos by hook instance.Improves the site editor load metric by at least 2%.
How?
We can cache the parsed result with a weak map.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast