Update table header gap #57671
Merged
Update table header gap #57671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Experimental
jasmussen
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
M only question is whether targetting that specific class is good practice or not. Perhaps @ntsekouras knows?
|
Size Change: +21 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
oandregal
approved these changes
Jan 9, 2024
oandregal
reviewed
Jan 9, 2024
| @@ -85,6 +85,10 @@ | |||
| tr { | |||
| border-bottom: 1px solid $gray-100; | |||
|
|
|||
| .dataviews-view-table-header-button { | |||
There was a problem hiding this comment.
We should do a second round of CSS naming consolidation at some point. We do .dataviews-view-grid__X but .dataviews-view-table-X. Not for this PR, though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tables are sorted an arrow is appended to the column header indicating the sort order. Currently there's no space between the label and the arrow which looks a little awkward:
This PR adds a small
gapto address this issue:To test: