Migrate 'dropdown menu' e2e tests to Playwright #57663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
Mamaduka
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
requested review from
WunderBart and
t-hamano
and removed request for
ntwb,
ajitbohra and
nerrad
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
t-hamano
reviewed
Jan 10, 2024
Comment on lines
+38
to
+39
| // Expect the first menu item to be focused. | ||
| await expect( menuItems.first() ).toBeFocused(); |
There was a problem hiding this comment.
From what I understand, the original test opens the Options menu every time it is tested, but this PR runs all tests after the Options menu opens for the first time. If so, I think this assertion might be unnecessary. This is because the last assertion of the previous test (Arrow back up to the first item.) ensures that the focus is on the first element.
Or is it better not to use test.step to maintain the original test specification? 🤔
There was a problem hiding this comment.
Each step expects the focus to start from the first menu item; this assertion just double-checks that.
Or is it better not to use test.step to maintain the original test specification?
Do you mean to create a new post for each test? That's usually the most expensive part of the tests, and we don't make any content assertions; I think re-using the same post should be okay.
There was a problem hiding this comment.
Do you mean to create a new post for each test?
It's okay to reuse the same post, but I thought it might be a good idea to reopen the Options menu for each tests.
What do you think?
There was a problem hiding this comment.
I don't have a strong opinion, but the current method should be okay. Even if you run each step separately, they will pass.
There was a problem hiding this comment.
I see, I don't have a strong opinion either, so let's go with this 👍
t-hamano
approved these changes
Jan 10, 2024
|
Thanks for the review, @t-hamano. It's much appreciated, as always 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
PR migrates
dropdown-menu.test.jse2e tests to Playwright.Why?
See #38851.
How?
The e2e test now uses
test.stepfor grouping assertions. A minor improvement for test runtime.Testing Instructions