"Multiple use" block validation logic improvement [with Playwright]

[fai-sal]

Why

• Improvement of this pull request "Multiple use" block validation logic improvement. #40901
• Updating the tests using playwright as suggested by @getdave here
• Creating new PR, since the old PR is almost 2years old and behaving unexpectedly.

What

• Fixes Avoid multiple block adding while "multiple" is false in block.json #38502

Co-authored-by: getdave [email protected]
Co-authored-by: Mamaduka [email protected]
Co-authored-by: scruffian [email protected]

[Mamaduka]

Thank you, @fai-sal!

The correct directory for Playwright e2e tests is test/e2e/specs/editor/various.

I also would recommend checking the project e2e test best practices documentation - https://developer.wordpress.org/block-editor/contributors/code/testing-overview/e2e/#best-practices.

[getdave]

Appreciate all your hard work here 🙇

The e2e tests will need to be rewritten to utilise Playwright APIs such as getByRole.

A lot of the await will be able to be removed as well. You should find it's a lot easier to author the tests as well.

[getdave]

Thanks for migrating to Playwright. A few comments about the test selectors 🙏

[fai-sal]

Hi @getdave, If you can allocate some time, can you please review the PR again. Thanks 🙇

[getdave]

I think we should look to land this in time for WP 6.5. I've put it on the board for that project which should ensure a number of 👀 on it.

[scruffian]

Left a few nits but this looks good to me.

Review points have been addressed

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @ihdk.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: ihdk.

Co-authored-by: delowardev <[email protected]>
Co-authored-by: fai-sal <[email protected]>
Co-authored-by: getdave <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: scruffian <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[getdave]

Let's bring this in. Thank you for the persistence here 🙇