Site Logo: Remove unnecessary 'block-editor' store subscription #57513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
|
Size Change: +8 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is similar to #57449.
PR removes an unnecessary 'block-editor' store subscription from the
LogoEditcomponent.Why?
The media
mediaUploadsetting is only used during theonFilesDropevent. We can use a static selector getter and grab the setting only when needed. It's a good practice to avoid store subscriptions when unnecessary.P.S. There's another store subscription in the
SiteLogocomponent, but settings are used during the render, so the same optimization cannot be applied.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2024-01-03.at.16.52.26.mp4