DataViews: use DropdownMenuRadioItem component when possible #57505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Feature] DataViews
|
Size Change: +33 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Jan 3, 2024
| // selecting a sorting option automatically deselects the | ||
| // previously selected one, even if it is displayed in | ||
| // another submenu. The field and direction are passed via | ||
| // the `value` prop. |
There was a problem hiding this comment.
We don't use the value right now, so this part of the comment could be removed, right?
There was a problem hiding this comment.
The value is required by radio items (both the DropdownMenuRadioItem component, the underlying ariakit implementation, and radio inputs in general). In the component's internal logic, it is necessary to distinguish each radio item from the others within the same radio group.
There was a problem hiding this comment.
Sure, just referring to The field and direction are passed via the value prop. part of comment. Is this part relevant?
There was a problem hiding this comment.
In my mind, it is — it complements the fact that name is very generic and doesn't include field and/or direction. But I appreciate that it could sound superfluous to other devs.
ntsekouras
reviewed
Jan 3, 2024
ntsekouras
reviewed
Jan 3, 2024
ntsekouras
approved these changes
Jan 3, 2024
ciampo
deleted the
feat/data-views-dropdown-menu-use-actual-menu-radio-items
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #55625, following feedback from @oandregal .
This PR refactors code around radio menu items, using the actual
DropdownMenuRadioItemwhere possible instead of the custom implementation.Why?
The custom implementation was added to workaround a limitation of the
DropdownMenuRadioItem, which doesn't allow a radio item to be "unchecked" once it's been checked (see this comment for extra context).How?
By tweaking the
nameandvalueof the radio groups, we can make sure that the "sorting" radio items update correctly (ie. get deselected).Testing Instructions
To load the Data View UI:
For this specific PR: