Make sure command palette toggle does not disappear while being clicked. #57420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: +19 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Jan 3, 2024
bph
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57415
What?
The icon of the Open Command Palette button in the 'site hub' disappears while the button is being activated. Screenshot:
Why?
It should not disappear.
How?
Targets the svg icon to set its fill color, much like the View Site link.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast