-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest cherry-picks for 6.4.x #57360
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…57063) # Conflicts: # test/integration/fixtures/blocks/core__image__deprecated-v3-add-align-wrapper.serialized.html # test/integration/fixtures/blocks/core__image__deprecated-v6-add-style-width-height.serialized.html
* Components: move ContextSystemProvider out of ui folder * Update imports * Remove context folder from ui * Update references in docs/comments * Fix path to older commit Co-authored-by: Marco Ciampini <[email protected]> * Update changelog --------- Co-authored-by: Marco Ciampini <[email protected]>
* convert typescript slot-fill-context.ts and slot-fill-provider.tsx * fix portalContainer type. * convert hooks to ts. * fix types * fix fillProps * convert slot.tsx * update Fill * fix typename. * fix dropdown v2 portal container type. * fix ref type * refactor * refactor SlotFillProvider * migrate SlotComponent to TS * convert useSlot * add update * fix ProviderProps * refactor type * refactor type * allow symbol to name prop. * refactor SlotComponentProps * refactor stroies and README * fix typo * remove comments. remove children from Slot. * refactor SlotComponentProps * Apply suggestions from code review Co-authored-by: Lena Morita <[email protected]> * Apply suggestions from code review Co-authored-by: Lena Morita <[email protected]> * refactor: newChildren to inline. * Remove unnecessary type variables. * fix type comments * Remove unnecessary Type Guards. Remove unnecessary Type Guards. And use `React.Key`. * remove type from jsdoc * refactor types * refactor types * Simplify the type of `slot`. * Remove the type specification and leave it to type inference. * fix types * remove story.js * update changelog * remove ts-nocheck * fix story filename. remove override bubblesVirtually attribute * replace useState to useMemo * switch to ts-expect-error in story. * fix mssing changelog https://github.com/WordPress/gutenberg/pull/53272/files/362b6d4405edd476df1f6479bb264dc9f51d6789#r1319926144 * add `children?: never` #51350 (comment) * use Record * use Record / Enable className only when bubblesVirtually: true. * Update packages/components/src/slot-fill/types.ts Co-authored-by: Marco Ciampini <[email protected]> * update changelog * use optional chain * fix WordPressComponentProps import --------- Co-authored-by: Lena Morita <[email protected]> Co-authored-by: Marco Ciampini <[email protected]>
mikachan
added
the
[Type] WP Core Ticket
Requires an upstream change from WordPress. Core Trac ticket should be linked.
label
Dec 23, 2023
Size Change: +126 B (0%) Total Size: 1.63 MB
ℹ️ View Unchanged
|
* Consolidate util colors and ui/utils colors * Move ui/utils space and update imports * Move remaining ui/utils files * Remove README * Update changelog * Remove old /ui/ references --------- Co-authored-by: Marin Atanasov <[email protected]>
Flaky tests detected in c970b00. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7308835371
|
To fix CI tests
This reverts commit f71313a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Type] WP Core Ticket
Requires an upstream change from WordPress. Core Trac ticket should be linked.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the latest cherry-picks for the next 6.4 point release: