Font Library: consolidate existing API rest endpoints. #57282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/fonts/font-library/class-wp-rest-autosave-font-families-controller.php ❔ lib/experimental/fonts/font-library/class-wp-rest-font-collections-controller.php ❔ phpunit/tests/fonts/font-library/wpRestFontCollectionsController/registerRoutes.php ❔ phpunit/tests/fonts/font-library/wpRestFontFamiliesController/base.php ❔ lib/experimental/fonts/font-library/font-library.php ❔ lib/load.php ❔ lib/experimental/fonts/font-library/class-wp-rest-font-families-controller.php ❔ phpunit/tests/fonts/font-library/wpRestFontCollectionsController/base.php ❔ phpunit/tests/fonts/font-library/wpRestFontCollectionsController/getFontCollection.php ❔ phpunit/tests/fonts/font-library/wpRestFontCollectionsController/getFontCollections.php ❔ phpunit/tests/fonts/font-library/wpRestFontFamiliesController/installFonts.php ❔ phpunit/tests/fonts/font-library/wpRestFontFamiliesController/uninstallFonts.php |
|
Size Change: +1 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6c4410f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7279815325
|
Co-authored-by: Jason Crist <[email protected]> Co-authored-by: Jeff Ong <[email protected]>
jffng
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Hi, I gave this a test and the font library is still working as expected.
The code changes are minimal and bring us closer to the work happening in the context of the API refactor.
I just want to confirm though, that PUT and PATCH endpoints still exist for the font-families route, and that is expected:
Yes, I think that's expected. |
bph
added
[Type] Code Quality
This was referenced Jan 3, 2024
youknowriad
added
Backported to WP Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
With this PR, we reduce the number of Font Library-related endpoints.
Old paths:
New paths:
Why?
How?
Testing Instructions
This seems to be a better alternative than: #57115