Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep Lock button it in the toolbar until unmounted #57229

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Keep Lock button it in the toolbar until unmounted #57229

merged 3 commits into from
Jan 4, 2024

Commits on Dec 20, 2023

  1. If the lock button has shown in the toolbar, keep it in the toolbar u… 

    …ntil unmounted.

If the block lock button has been shown, we don't want to remove it from the toolbar until the toolbar is rendered again without it. Removing it beforehand can cause focus loss issues, such as when unlocking the block from the modal. It needs to return focus from whence it came, and to do that, we need to leave the button in the toolbar.
    @jeryj
    jeryj committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    89621c4 View commit details
    Browse the repository at this point in the history

  2. Remove unused prop and switch selectedBlockClientId[0] to equivalent … 

    …blockClientId
    @jeryj
    jeryj committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    2672ad1 View commit details
    Browse the repository at this point in the history

  3. Add e2e test to verify focus from modal behavior

    @jeryj
    jeryj committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    7123d3a View commit details
    Browse the repository at this point in the history