Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snackbar: Remove __unstableHTML prop from TS #57218

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Snackbar: Remove __unstableHTML prop from TS #57218

merged 2 commits into from
Dec 19, 2023

Conversation

mirka
Copy link
Member

@mirka mirka commented Dec 19, 2023

Fixes #56767

What?

Removes the __unstableHTML prop from the TypeScript type definitions for Snackbar, which was erroneously included from the Notice types.

Why?

The feature has never been implemented for Snackbar, and a discussion in #57067 led us to decide to keep it unimplemented for now.

Testing Instructions

See that __unstableHTML is no longer included in the props table for the Snackbar Storybook docs. Alternatively, verify in your IDE that adding a __unstableHTML prop to a Snackbar results in a TS error.

@mirka mirka added [Type] Developer Documentation Documentation for developers [Package] Components /packages/components labels Dec 19, 2023
@mirka mirka self-assigned this Dec 19, 2023
@mirka mirka requested a review from ajitbohra as a code owner December 19, 2023 13:28
@mirka mirka requested review from ntsekouras and a team December 19, 2023 13:30
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Lena!

@mirka mirka merged commit 1dedeab into trunk Dec 19, 2023
54 checks passed
@mirka mirka deleted the fix/snackbar-ts branch December 19, 2023 16:37
@github-actions github-actions bot added this to the Gutenberg 17.4 milestone Dec 19, 2023
artemiomorales pushed a commit that referenced this pull request Jan 4, 2024
* Snackbar: Remove `__unstableHTML` prop from TS

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notices - __unstableHTML works for default, but not in snackbar
2 participants