-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Avoid keyboard dismiss when interacting text blocks #57070
Merged
fluiddot
merged 10 commits into
trunk
from
rnmobile/fix/avoid-keyboard-dismiss-when-interacting-text-blocks
Dec 18, 2023
Merged
[RNMobile] Avoid keyboard dismiss when interacting text blocks #57070
fluiddot
merged 10 commits into
trunk
from
rnmobile/fix/avoid-keyboard-dismiss-when-interacting-text-blocks
Dec 18, 2023
Commits on Dec 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b6f237f - Browse repository at this point
Copy the full SHA b6f237fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a71b1c5 - Browse repository at this point
Copy the full SHA a71b1c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63913e8 - Browse repository at this point
Copy the full SHA 63913e8View commit details -
Add
blurOnUnmount
to Aztec input state manager.This function will help us to deal with the special case of unfocusing an Aztec view upon unmounting.
Configuration menu - View commit details
-
Copy full SHA for 634867f - Browse repository at this point
Copy the full SHA 634867fView commit details -
Dismiss keyboard when Aztec view unmounts
This was previously handled in the `RichText` component.
Configuration menu - View commit details
-
Copy full SHA for d3fb486 - Browse repository at this point
Copy the full SHA d3fb486View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35fa91f - Browse repository at this point
Copy the full SHA 35fa91fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1af3437 - Browse repository at this point
Copy the full SHA 1af3437View commit details
Commits on Dec 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 17dcda5 - Browse repository at this point
Copy the full SHA 17dcda5View commit details
Commits on Dec 18, 2023
-
[Mobile] - Android - Bring the Keyboard back when closing modals (#57069
) * React Native Bridge - Android - Introduces showAndroidSoftKeyboard to show the keyboard if there's a focused TextInput * Mobile - Bottom Sheet - Adds usage of showAndroidSoftKeyboard when closing the Modal so it shows the Keyboard on Android for focused TextInputs * React Native Bridge - Android - Introduces hideAndroidSoftKeyboard to hide the keyboard without triggering blur events * React Native Bridge - Remove console warnings for unsupported methods, as their names are self-explanatory. * Update showAndroidSoftKeyboard to take into account when the window focus changed, when we show the Modals these are shown on top of the editor activity. It also adds an option to delay this for full screen modals * Mobile - BottomSheet - Enable hardwareAccelerated and useNativeDriverForBackdrop props to improve performance on Android * Update snapshots * Removes hasWindowFocus condition as it is not being called hence not needed * Refactor showAndroidSoftKeyboard to split into several functions, it also removes the delay functionality as it is no longer needed. It fixes an issue where mKeyboardRunnable was not being set. It removes the delay logic from the Bottom Sheet component and the bridge. * Updates createShowKeyboardRunnable to get the activity within the runnable instead of getting it as an param * Remove unneeded check
Gerardo Pacheco authoredDec 18, 2023 Configuration menu - View commit details
-
Copy full SHA for 71b3409 - Browse repository at this point
Copy the full SHA 71b3409View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2041a2 - Browse repository at this point
Copy the full SHA a2041a2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.