Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] - Android - Bring the Keyboard back when closing modals #57069

Merged
merged 11 commits into from
Dec 18, 2023
Merged

[Mobile] - Android - Bring the Keyboard back when closing modals #57069

merged 11 commits into from
Dec 18, 2023

Commits on Dec 14, 2023

  1. React Native Bridge - Android - Introduces showAndroidSoftKeyboard to… 

    … show the keyboard if there's a focused TextInput
    Gerardo committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    da6d429 View commit details
    Browse the repository at this point in the history

  2. Mobile - Bottom Sheet - Adds usage of showAndroidSoftKeyboard when cl… 

    …osing the Modal so it shows the Keyboard on Android for focused TextInputs
    Gerardo committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    39e7f6c View commit details
    Browse the repository at this point in the history

  3. React Native Bridge - Android - Introduces hideAndroidSoftKeyboard to… 

    … hide the keyboard without triggering blur events
    Gerardo committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    b961e12 View commit details
    Browse the repository at this point in the history

  4. React Native Bridge - Remove console warnings for unsupported methods… 

    …, as their names are self-explanatory.
    Gerardo committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    ef48c7f View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Update showAndroidSoftKeyboard to take into account when the window f… 

    …ocus changed, when we show the Modals these are shown on top of the editor activity.

It also adds an option to delay this for full screen modals
    Gerardo committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    79d62e8 View commit details
    Browse the repository at this point in the history

  2. Mobile - BottomSheet - Enable hardwareAccelerated and useNativeDriver… 

    …ForBackdrop props to improve performance on Android
    Gerardo committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    b4257ec View commit details
    Browse the repository at this point in the history

  3. Update snapshots

    Gerardo committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    a29ccfd View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Removes hasWindowFocus condition as it is not being called hence not … 

    …needed
    Gerardo committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    fc001f5 View commit details
    Browse the repository at this point in the history

  2. Refactor showAndroidSoftKeyboard to split into several functions, it … 

    …also removes the delay functionality as it is no longer needed. It fixes an issue where mKeyboardRunnable was not being set.

It removes the delay logic from the Bottom Sheet component and the bridge.
    Gerardo committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    b0bfdf1 View commit details
    Browse the repository at this point in the history

  3. Updates createShowKeyboardRunnable to get the activity within the run… 

    …nable instead of getting it as an param
    Gerardo committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    1db7e47 View commit details
    Browse the repository at this point in the history

  4. Remove unneeded check

    Gerardo committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    1cb8d7f View commit details
    Browse the repository at this point in the history