Framework: Bundle the BlockTools component within BlockCanvas #56996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
getdave,
jeryj,
glendaviesnz,
ellatrix and
t-hamano
youknowriad
commented
Dec 12, 2023
| @@ -60,7 +59,6 @@ export default function EditorWithUndoRedo() { | |||
| label="Redo" | |||
| /> | |||
| <BlockToolbar hideDragHandle /> | |||
There was a problem hiding this comment.
I noticed that hideDragHandle is always passed to this component. It's only left as false in the case of the "popover toolbar" which is rendered by the framework, this means that we should probably change the default value of this prop to "true".
|
Size Change: -216 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
youknowriad
commented
Dec 12, 2023
| > | ||
| { children } | ||
| </WritingFlow> | ||
| </> | ||
| </BlockTools> |
There was a problem hiding this comment.
Only downside here is that we'll have two divs (BlockTools div and WritingFlow div), we could potentially merge the two later.
There was a problem hiding this comment.
For non iframe, maybe, but I don't think it's that important. For iframe writing flow already does not produce a div.
youknowriad
commented
Dec 12, 2023
| <EditorStyles styles={ styles } /> | ||
| { children } | ||
| </Iframe> | ||
| </BlockTools> |
There was a problem hiding this comment.
The BlockTools div could be optional maybe, its behavior could be automatically added to the Iframe wrapper or something.
|
Flaky tests detected in b446ac2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7188481224
|
ellatrix
reviewed
Jun 6, 2024
| name="editor-canvas" | ||
| <BlockTools | ||
| __unstableContentRef={ localRef } | ||
| style={ { height, display: 'flex' } } |
There was a problem hiding this comment.
Why did you decide to add flex here? This is strange
There was a problem hiding this comment.
I can't really tell at this point 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #53874
What?
The
BlockToolscomponent has always been a weird component that is a bit hard to describe for third-party block editor developers. It's used to render the block toolbar in the "default block toolbar mode" but also attaches some mandatory event handlers for the block editor. It's hard to explain how to use it and where to use it properlyThis PR solves that issue by bundling it within
BlockCanvascomponent. It also updates the platform docs to explain how to use the related BlockToolbar component.Testing Instructions
Check the post, site and widget editors. Check things like device preview, resizing... Things should work as expected.