Site editor: do not use navigator's internal classname #56911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor screens in the site editor sidebar
ciampo
added
[Feature] UI Components
ciampo
requested review from
oandregal,
jasmussen,
ntsekouras and
aaronrobertshaw
ciampo
commented
Dec 8, 2023
| @@ -17,8 +20,3 @@ | |||
| margin: 0 $canvas-padding; | |||
| padding: $canvas-padding 0; | |||
| } | |||
|
|
|||
| .edit-site-sidebar__content > div { | |||
There was a problem hiding this comment.
I believe that NavigatorScreens are the only div elements that are direct children of .edit-site-sidebar__content, and therefore I moved those styles under the same .edit-site-sidebar__screen-wrapper selector
There was a problem hiding this comment.
For now at least that's true, so I guess that's fine.
|
Size Change: -20 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 86607c0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7144475382
|
aaronrobertshaw
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
LGTM 👍
✅ Tests as advertised while navigating around Site Editor nav screens
✅ Relocation of nav screen padding rule makes sense, I didn't see any non-screen divs
ntsekouras
approved these changes
Dec 12, 2023
| @@ -17,8 +20,3 @@ | |||
| margin: 0 $canvas-padding; | |||
| padding: $canvas-padding 0; | |||
| } | |||
|
|
|||
| .edit-site-sidebar__content > div { | |||
There was a problem hiding this comment.
For now at least that's true, so I guess that's fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactors the styles applied in #48822 to
NavigatorScreencomponents in the site editor sidebar, so that the internal.components-navigator-screenclassname is not used.Why?
We should not use internal component's classnames, as they are not considered part of the public APIs of such components.
How?
By adding a custom classname to the
NavigatorScreencomponent, and using the new classname instead of the private classname to apply the required styles.Testing Instructions
trunk, specifically around the scrollbar styles