feat: Add Hook to monitor network connectivity status #56861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is non-functioning currently.
This bridge will be required for the planned JavaScript Hook to monitor connection status.
Provides React Hook for monitoring the network connection status via the bridge to the host app.
This reverts commit a8d3660.
Semicolon is unnecessary. Co-authored-by: Tanner Stokes <[email protected]>
This bridge enables monitoring the connection status on Android.
Allow the Android platform to request the current network connection status.
The Demo editor fails to build without a mocked bridge method.
dcalhoun
added
Mobile App - i.e. Android or iOS
This was referenced Dec 7, 2023
Merged
|
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
|
Flaky tests detected in aadf8c6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7128077772
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR supersedes the reverted #56609.
Related
What?
Add a React Hook for monitoring the network connection status via the bridge to
the host app.
Why?
The network connection status will enable future features improving the UX when
a user's network connection changes, e.g. displaying status indicators.
Fixes wordpress-mobile/gutenberg-mobile#6409.
How?
Add a
useIsConnectedReact Hook that invokes bridge methods retrieving andmonitoring the network connection status from the host app. Relying upon the
host app will result in a single source of truth and mitigate conflicting
statuses.
Testing Instructions
Checkout this branch within the
gutenberg-mobilesubmodule.Start the Metro server via
npm run start:reset.Apply the following patch:
Test Diff
Configure the app to load the local Metro server:
LOCAL_GUTENBERG=true bundle exec pod install.localGutenbergMobilePathwithinlocal-builds.gradle.Build and run the WordPress app.
Launch the editor and verify the connection status displayed is accurate.
Toggle airplane mode, verify the connection status displayed is accurate.
Testing Instructions for Keyboard
n/a, this internal tool introduces no user-facing changes.
Screenshots or screencast
n/a, this internal tool introduces no visible changes.