Pattern inserter: fix Broken preview layout #56814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +2 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5c983f4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7111646610
|
|
Thanks for the review, @jasmussen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56812
Related to #56011
What?
This PR fixes an issue where the pattern layout is broken in the main inserter and quick inserter.
Why?
In #56011, the following styles have been added to center the block in the block preview vertically.
However, this selector also affects the pattern preview in the pattern list.
The pattern preview consists of the following hierarchy.
If the preview element (
.block-editor-block-preview__container) has a height of 100%, the element will extend to the full height of the parent element, and the pattern name (.block-editor-patterns__pattern-details) that exists in parallel will jump out from the parent element.How?
Applies
height:100%style to the block preview and the block style preview only (.block-editor-inserter__preview-container .block-editor-block-preview__container).Testing Instructions
Screenshots or screencast
2a80be2ff3ae756c4e2097778d92955f.mp4