-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix top position and height of Pattern Modal Sidebar #56787
Conversation
Size Change: -50 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
Flaky tests detected in b8d2e9f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7102476215
|
59647a9
to
b8d2e9f
Compare
.block-editor-block-patterns__source-filter select.components-select-control__input { | ||
height: 40px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I searched the whole project for the keyword source-filter
, but there doesn't seem to be any element with a class name containing that keyword. It existed in the past, but I don't think it exists now.
.block-editor-inserter__block-patterns-tabs-container, | ||
.block-editor-block-patterns-explorer__sidebar { | ||
.block-editor-inserter__block-patterns-tabs-container { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will also remove the following selector.
.block-editor-block-patterns-explorer__sidebar nav {
height:100%;
}
However, it seems that there are no elements matching this selector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot, thank you for fixing :)
Contains fix for #56740
What?
This PR fixes the following two issues in the Pattern Modal Sidebar.
Why?
I suspected that #51829, which added 4px padding to the top of the modal content, was the cause, but it doesn't seem to be the direct cause.
This might have been a pre-existing problem, or some change may have caused this problem.
This sidebar (
.block-editor-block-patterns-explorer__sidebar
) is absolutely positioned, withbottom: 0
applied. However, sinceheight:100%
is also applied at the same time, the height will protrude.How?
I moved the top position of the sidebar up 4px.
I removed the unused code at the same time as the affecting code.
Testing Instructions
Screenshots or screencast
c38f63fecf28d186736622722e1d323c.mp4