Perf: reopen inspector for remaining tests #56780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 1e43cab. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7099073476
|
youknowriad
reviewed
Dec 5, 2023
| @@ -173,6 +179,9 @@ test.describe( 'Post Editor Performance', () => { | |||
| } ); | |||
|
|
|||
| await type( paragraph, metrics, 'typeWithoutInspector' ); | |||
|
|
|||
| // Open the inspector again. | |||
| await editor.openDocumentSettingsSidebar(); | |||
There was a problem hiding this comment.
We could also put this in beforeEach somehow. But this is good.
There was a problem hiding this comment.
Maybe it would be worth dumping all the preferences and setting them in the beforeEach hook to ensure an identical state for each test?
youknowriad
approved these changes
Dec 5, 2023
|
Let's get it in so it's corrected asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #56753 a test was added that types with the inspector sidebar closed, but this closing is persisted and affects the remaining tests, so we should open it again at the end.
See the drop for
Block Select: https://www.codevitals.run/project/gutenbergWhy?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast