DataViews: do not export strings constants #56754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Experimental
|
I know that I shared this opinion before that I don't like much exported strings like that but I also don't hold this opinion too strongly (compared to others :P) so I'm ok with whatever the majority thinks :) |
|
Size Change: +71 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
I'm on the fence on this one. Not strong opinion, but lean towards removing them. From the consumer point of view, is it really useful to have them? They are indeed API surface, like the block or redux store names are, tough perhaps it's enough to have them documented. |
ntsekouras
reviewed
Dec 4, 2023
| OPERATOR_IN, | ||
| OPERATOR_NOT_IN, | ||
| } from './constants'; | ||
| export { VIEW_LAYOUTS } from './constants'; |
There was a problem hiding this comment.
I think what we would need here is function like getViewLayouts as in the future we could allow registering more? 🤔
There was a problem hiding this comment.
Yes, we could follow what we did with the "core/blocks" store I think.
There was a problem hiding this comment.
I think what we would need here is function like getViewLayouts as in the future we could allow registering more? 🤔
Do you mean as a follow-up to substitute VIEW_LAYOUTS but we still do this PR, correct?
I've left a comment at #56721 (comment) for VIEW_LAYOUTS:
The VIEWS_LAYOUT is used for two things
- Detect supports, which also can be removed if we go with this API for the list view/preview DataViews: iterate on list view #56746
- Use the icons in the sidebar. What do we do with this one? Export the icons directly or provide a utility such as getIconForViewType( viewType )?
There was a problem hiding this comment.
We could do it in a follow up, yes.
youknowriad
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
Follow-up to #56721 (comment)
What?
Remove the exported strings from the
dataviewspackage.Why?
Each consumer should maintain its own.
How?
Removes the export and creates new constants in the
edit-sitepackage.Testing Instructions