Platform Docs: Add trusted by section #56749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
commented
Dec 4, 2023
| title: 'Day One', | ||
| img: require( '@site/static/img/dayone.png' ).default, | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
Happy to add more "Gutenberg" users, these are the ones I'm aware of.
There was a problem hiding this comment.
The Drupal extension might be worth a mention?
There was a problem hiding this comment.
I thought about it but at the moment the Drupal doesn't really use the block editor package as a framework but they reuse the whole plugin somehow. I know they're working on it to improve the integration so I left it out for now.
|
Size Change: -85 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
It's always a bit tricky balancing logos like this, but my drive-by feedback would be to try and improve that a bit. Something like: 
Using monochrome or grayscale variants could help too, depending on how much attention you want to bring to this section. |
|
@jameskoster I guess I could use some help with that :P. What tools do you use these days to edit things like that? |
|
It's probably fine to do with css by adjusting the height for each logo accordingly? If you wanted to copy the mockup above:
Otherwise here are the resized images, though ideally they should be transparent svgs: 
|
|
@jameskoster Are you sure about these heights? Did you use the same images, cause I got something completely different :P ? I can try to approximate that though. |
|
I pushed a commit, here is how it looks now 
|
Apologies, no, I cropped them.
That looks okay to me, outside of diving into the code and replacing the images with svgs which regrettably I don't have time to do right now. |
youknowriad
requested review from
a team,
draganescu and
chad1008
and removed request for
a team
ntsekouras
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #53874
This PR adds a "trusted by" section to the Gutenberg as a framework docs site. I'm also removing some empty documentation pages for now. We may want to add these back later.
I think this site needs some design love but I'm hoping @jameskoster @jasmussen or @SaxonF could help with some of that in follow-ups.
Check the site by doing