Block lib: use RichText.isEmpty where forgotten #56726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +29 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Pretty simple and straightforward change, and lots of unit tests and e2e tests exist for these blocks, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A preparatory PR for #43204.
In some cases we are not using
RichText.isEmptyto check emptiness, which causes some failures in #43204 when changing the type.Why?
The rich text data type is not falsy when empty. The length must be checked, or better, use the existing
RichText.isEmptyhelper which we already use in most places.How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast