Code block: should use RichText (native) #56724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Code Quality
|
Size Change: +489 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
geriux
approved these changes
Dec 4, 2023
|
Thanks @geriux! |
|
@ellatrix & @geriux can either of you explain why this change was needed. I need to do some further testing but this appears to be related to the Code Block being broken with I need to do some further investigation to see if there are actually changes to the RichText block that are causing the recent issue reported in the pending WP 6.5 release. Ref: #59548 |
|
To follow up, there is a string of changes around white space and the Ref: #58659 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ideally both the mobile version of code uses the RichText just like the web version.
Related: #43204 (though we don't absolutely need this PR, I thought it's good to clean this up)
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast