DataViews: make Actions styles the same as any other column header
#56654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
jasmussen,
ntsekouras,
youknowriad,
jameskoster,
SaxonF and
jorgefilipecosta
oandregal
added
[Type] Experimental
oandregal
changed the title
Actions column header's styles the same as othersActions styles the same as any other column header
oandregal
commented
Nov 29, 2023
| @@ -34,9 +34,15 @@ | |||
| } | |||
| th { | |||
| text-align: left; | |||
| font-weight: normal; | |||
| padding: 0 $grid-unit-20 $grid-unit-20; | |||
There was a problem hiding this comment.
padding was not being used, as far as I could tell – so I removed it.
oandregal
commented
Nov 29, 2023
|
Size Change: -11.4 kB (-1%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Nov 30, 2023
| * This makes the Actions column header to use the same styles as the other ones. | ||
| * The other column headers use the .components-button styles. | ||
| */ | ||
| &[data-field-id="actions"] { |
There was a problem hiding this comment.
Should this just be [data-field-id], or even something higher up? Mainly it seems like all items in this row should always be styled the same, even future additions.
There was a problem hiding this comment.
Yeah, good point. I think we can just target the th. The mismatch Joen describes can be observed by adding a field that is not hideable or sortable.
There was a problem hiding this comment.
Good one, thanks! Pushed 43190dc
|
I have a small concern that there's no indication about which cells are interactive and which are not, they all look identical. This issue could become more pronounced when we add inline editing down the road. Probably fine for now, but also could be a detail to revisit later. |
derekblank
pushed a commit
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
What?
Makes the styles for the
Actionscolumn header be the same as other column headers.Testing Instructions