HeadingLevelDropdown: Remove unnecessary isPressed prop #56636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
|
Size Change: -4 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
t-hamano
force-pushed
the
quality/heading-dropdown-refactor
branch
from
dd6cc3b to
efad66b
Compare
t-hamano
force-pushed
the
quality/heading-dropdown-refactor
branch
from
efad66b to
9af710c
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
changed the title
t-hamano
force-pushed
the
quality/heading-dropdown-refactor
branch
from
9af710c to
2fb0b1c
Compare
|
@Mamaduka Sorry, I forgot to add the co-author when merging 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the
isPressedproperty from the dropdown menu icon of theHeadingLevelDropdowncomponent.Why?
HeadingLevelIcondoes not receiveisPressedprop.Testing Instructions
Insert a Heading block that uses this component and confirm that changing the heading level works as before.