Move InserterButton from components package to block-editor package #56494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekblank
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
….com/WordPress/gutenberg into rnmobile/move-mobile-inserter-button
|
Flaky tests detected in f649c78. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7013318599
|
fluiddot
approved these changes
Nov 27, 2023
packages/block-editor/src/components/block-variation-picker/index.native.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/block-types-list/index.native.js
Outdated
Show resolved
Hide resolved
derekblank
added
the
Mobile App - Automation
derekblank
force-pushed
the
rnmobile/move-mobile-inserter-button
branch
from
8e16d06
to
f649c78
Compare
@fluiddot Thanks for the review - I updated the relative import paths and linked the block-experiments PR. I also opened a companion Gutenberg Mobile PR, but I'm not sure it really needs one (or at least, I don't think it needs an update to the RELEASE-NOTES.txt in Gutenberg Mobile). WDYT? |
@derekblank The only reason for creating the companion PR is due to the update in the |
|
@fluiddot I agree. I'll update the block-experiments ref in the Gutenberg Mobile PR once the block-experiments PR is approved/merged. 👍 |
@derekblank I've approved all the PRs, feel free to start updating the references and merge them. Thanks 🙇 ! |
derekblank
added a commit
that referenced
this pull request
Dec 7, 2023
…56494) * Move mobile InserterButton from components package to block-editor package * Add @wordpress/primitives to block-editor package dependencies * Update react-native-editor CHANGELOG * Move SVG and Path imports from @wordpress/primitives to @wordpress/components * Update components package CHANGELOG * Update InserterButton import paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR moves the mobile
InserterButtonfrom the components package to the block-editor package.Why?
There is an ongoing effort to remove block-editor package dependencies in native files from the components package in order to eliminate cyclic dependencies:
block-editorpackage in native files within thecomponentspackage #52692How?
Moves code and code references to
InserterButtonfrom the components package to the block-editor package.Testing Instructions