Update image block save to only save align none class #56449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Bug
draganescu
requested review from
artemiomorales and
michalczaplinski
as code owners
|
Size Change: +6.82 kB (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fe091f1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7117243983
|
|
Interesting, this change does break something it appears that now there is an |
ajlende
reviewed
Dec 5, 2023
There was a problem hiding this comment.
This went deeper than I expected for a one line change.
As far as I can tell, the { align: 'none' } attribute only ever came from the shortcode transform for the image block. (Or, technically, someone could have manually entered it in the code view.) Surprisingly, the regex from raw HTML for the attribute didn't even include it despite the alignnone class being used in TwentyThirteen & TwentyTwenty default themes. Not sure if that's a bug, but if it is, it's been around for more than 6 years and is probably considered functionality by someone at this point [ref].
gutenberg/packages/block-library/src/image/transforms.js
Lines 221 to 226 in 66078c4
Because of this code, any align* class has been considered valid, not just the ones supported by the block supports and alignnone. If we really want to maintain the old behavior, we can't change this line. As we've seen, this doesn't cause the classes to be doubled up, so I think it's okay. But it's probably worthwhile adding a comment as to why.
We could also just consider everything other than |
I think this is fair. |
draganescu
changed the title
ajlende
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #55954 to update the save function of the image block to no longer set the align class on render.
That was an oversight of the original PR. #55954 did work - not ending up with duplicate classes - because of implementation consistency :) the name of the class set by the support is the same as the one set by the save function and it would just be replaced.
This should be a benign change, but @youknowriad 's observation about the complexity of this block is something to keep an eye on.