Site Editor: Apply box-sizing:reset to popover component
#56325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
youknowriad
reviewed
Nov 20, 2023
|
Size Change: +35 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
I see, I'd like to close this PR and try that approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56190
What?
This PR fixes an issue where a scrollbar may appear when a popover is rendered in the Site Editor.
Before
After
Why?
Popovers may be rendered outside of the
.edit-sitewrapper. Therefore, thebox-sizing:border-boxreset style is not applied.How?
Added
.components-popoverto the class to reset. This approach is also taken by the Post Editor.Testing Instructions